Change in vdsm[master]: hostdev: add hostdev device definition

mpolednik at redhat.com mpolednik at redhat.com
Fri Mar 6 12:27:36 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: add hostdev device definition
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/37700/10/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 185: def detach_detachable(device_name, only_get_params=False):
Line 186:     libvirt_device, device_params = _get_device_ref_and_params(device_name)
Line 187: 
Line 188:     if only_get_params:
Line 189:         return device_params
> I think it would be better (= nicer and more readable) if we instead add a 
very true, done!
Line 190: 
Line 191:     iommu_group = device_params['iommu_group']
Line 192: 
Line 193:     if device_params['capability'] in _UDEV_REQUIRING_CAPS:


-- 
To view, visit https://gerrit.ovirt.org/37700
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list