Change in vdsm[master]: lvm: Adds autobackup param in changelv and set the default v...

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 6 11:26:06 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lvm: Adds autobackup param in changelv and set the default value to false
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38195/2//COMMIT_MSG
Commit Message:

Line 19: of params in a tuple format and have some mandatory options.
Line 20: This will allow to break the lvm call if any thing called with
Line 21: different option values in the tuple list which are now mandatory
Line 22: to have some constant/'already defined' value.
Line 23: ex:- changelv(vg, lvs, ('-autobackup', 'y'))
I'm not sure what do you mean here - is there a conflict between the new option and calling with ('autobackup', 'y')?
Line 24: 
Line 25: Change-Id: I8190878fe071fad46800e666795b94779d745abf


-- 
To view, visit https://gerrit.ovirt.org/38195
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list