Change in vdsm[master]: host stats: Add number of in/out migrations

danken at redhat.com danken at redhat.com
Fri Mar 6 10:48:18 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: host stats: Add number of in/out migrations
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38420/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Adds number of incoming and outgoing VM migrations into HostStats.
Line 10: 
Line 11: Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af
Line 12: Bug-Url: https://bugzilla.redhat.com/1113664
Pardon me, but cannot the client do the math by itself?

We report all VMs' statuses in getVMList and getAllVMStats. Why does vdsm need to do anything else?

The fact that we report the number of running VMs is a sad fact of the ancient past. Why do we need to add more of that?


-- 
To view, visit https://gerrit.ovirt.org/38420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list