Change in vdsm[master]: v2v: janitorial: use the response module

fromani at redhat.com fromani at redhat.com
Fri Mar 6 09:26:32 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: v2v: janitorial: use the response module
......................................................................

v2v: janitorial: use the response module

This patch makes v2v.py use the response module.

Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/v2v.py
1 file changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/38447/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 4fbecf0..18f59d9 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -22,8 +22,8 @@
 
 import libvirt
 
-from vdsm.define import errCode, doneCode
 from vdsm import libvirtconnection
+from vdsm import response
 
 import caps
 
@@ -39,7 +39,7 @@
 
 def get_external_vms(uri, username, password):
     if not supported():
-        return errCode["noimpl"]
+        return response.error("noimpl")
 
     try:
         conn = libvirtconnection.open_connection(uri=uri,
@@ -47,8 +47,7 @@
                                                  passwd=password)
     except libvirt.libvirtError as e:
         logging.error('error connection to hypervisor: %r', e.message)
-        return {'status': {'code': errCode['V2VConnection']['status']['code'],
-                           'message': e.message}}
+        return response.error('V2VConnection', e.message)
 
     with closing(conn):
         vms = []
@@ -67,7 +66,7 @@
             for disk in params['disks']:
                 _add_disk_info(conn, disk)
             vms.append(params)
-        return {'status': doneCode, 'vmList': vms}
+        return response.success(vmList=vms)
 
 
 def _mem_to_mib(size, unit):


-- 
To view, visit https://gerrit.ovirt.org/38447
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I678e764a2895e7c34df6852759b1d43baeb687a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list