Change in vdsm[master]: tests: bootstrap changeBlockDev tests

fromani at redhat.com fromani at redhat.com
Fri Mar 6 08:08:30 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: bootstrap changeBlockDev tests
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/38391/3/tests/vmTests.py
File tests/vmTests.py:

Line 1312:                     virtError=libvirt.VIR_ERR_ACCESS_DENIED)
Line 1313: 
Line 1314:                 res = fakevm.changeCD({})
Line 1315: 
Line 1316:                 expected_error = define.errCode['changeDisk']['status']
> expected_status?
Sounds better, will change.
Line 1317:                 self.assertEqual(res['status']['code'],
Line 1318:                                  expected_error['code'])
Line 1319:                 self.assertEqual(res['status']['message'],


Line 1316:                 expected_error = define.errCode['changeDisk']['status']
Line 1317:                 self.assertEqual(res['status']['code'],
Line 1318:                                  expected_error['code'])
Line 1319:                 self.assertEqual(res['status']['message'],
Line 1320:                                  expected_error['message'])
> Why not assertEqual(res['status'], expected_status)?
No good reason. Will change.


-- 
To view, visit https://gerrit.ovirt.org/38391
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list