Change in vdsm[master]: net: sourceroute: demote error log message

amuller at redhat.com amuller at redhat.com
Thu Mar 5 16:46:41 UTC 2015


Assaf Muller has posted comments on this change.

Change subject: net: sourceroute: demote error log message
......................................................................


Patch Set 1:

The issue of course is not a missing IP address or netmask, but is a missing default gateway. Networks without a gateway are perfectly valid, just not for source routing. I don't remember how deep this code path is (Should it expect a gateway present at this point)? Anyhow, I think that a network without a gateway is a 'supported' or 'expected' use case and perhaps even warning is too harsh.

If the admin screwed up and he meant to supply a gateway when he configured his DHCP server, he'll have many other indicators that he screwed up anyway, the VDSM log will probably be the last place he'd look.

-- 
To view, visit https://gerrit.ovirt.org/38429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list