Change in vdsm[master]: net: sourceroute: demote error log message

danken at redhat.com danken at redhat.com
Thu Mar 5 16:22:48 UTC 2015


Dan Kenigsberg has uploaded a new change for review.

Change subject: net: sourceroute: demote error log message
......................................................................

net: sourceroute: demote error log message

DHCP server may provide vdsm with partial IP information (one of IPADDR,
NETMASK or GATEWAY is missing). This is not Vdsm's fault, and should not
marked as an error.

Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/__init__.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/38429/1

diff --git a/vdsm/network/configurators/__init__.py b/vdsm/network/configurators/__init__.py
index a3c7567..6e14a2d 100644
--- a/vdsm/network/configurators/__init__.py
+++ b/vdsm/network/configurators/__init__.py
@@ -131,10 +131,11 @@
                                           ip.gateway))
             if (ip.gateway in (None, '0.0.0.0')
                or not ip.ipaddr or not ip.netmask):
-                    logging.error('invalid input for source routing: name=%s, '
-                                  'addr=%s, netmask=%s, gateway=%s',
-                                  netEnt.name, ip.ipaddr, ip.netmask,
-                                  ip.gateway)
+                    logging.warning(
+                        'invalid input for source routing: name=%s, '
+                        'addr=%s, netmask=%s, gateway=%s',
+                        netEnt.name, ip.ipaddr, ip.netmask,
+                        ip.gateway)
             else:
                 StaticSourceRoute(netEnt.name, self, ip.ipaddr, ip.netmask,
                                   ip.gateway).configure()


-- 
To view, visit https://gerrit.ovirt.org/38429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list