Change in vdsm[ovirt-3.5]: qemu-img: check/use "-T src_cache" option in convert/rebase ...

amureini at redhat.com amureini at redhat.com
Thu Mar 5 14:30:19 UTC 2015


Allon Mureinik has posted comments on this change.

Change subject: qemu-img: check/use "-T src_cache" option in convert/rebase when available
......................................................................


Patch Set 1:

(2 comments)

+1 on the code, see comment on the commit msg

https://gerrit.ovirt.org/#/c/38413/1//COMMIT_MSG
Commit Message:

Line 17: 
Line 18: This patch is testing if qemu-img has the new "-T src_cache" option available
Line 19: for convert and rebase commands and using it with "-T none" when true.
Line 20: 
Line 21: Change-Id: Iab9c2abb22814c2660cd05180537db9e35a34636
Should have the same change-id as the patch in master: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690
Line 23: Signed-off-by: Amador Pahim <apahim at redhat.com>
Line 24: Reviewed-on: http://gerrit.ovirt.org/36308
Line 25: Reviewed-by: Nir Soffer <nsoffer at redhat.com>


Line 18: This patch is testing if qemu-img has the new "-T src_cache" option available
Line 19: for convert and rebase commands and using it with "-T none" when true.
Line 20: 
Line 21: Change-Id: Iab9c2abb22814c2660cd05180537db9e35a34636
Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690
Should use bug 1199141, the z-stream clone.
Sorry for not noticing earlier.
Line 23: Signed-off-by: Amador Pahim <apahim at redhat.com>
Line 24: Reviewed-on: http://gerrit.ovirt.org/36308
Line 25: Reviewed-by: Nir Soffer <nsoffer at redhat.com>


-- 
To view, visit https://gerrit.ovirt.org/38413
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab9c2abb22814c2660cd05180537db9e35a34636
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list