Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
fromani at redhat.com
fromani at redhat.com
Thu Mar 5 13:48:39 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................
Patch Set 5:
(3 comments)
minor comments
https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 28:
Line 29: def __init__(self, conf, log, **kwargs):
Line 30: super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: self._deviceParams = {}
Line 32: self.macAddr = kwargs.get('macAddr')
why not _private?
Line 33:
Line 34: def detach(self):
Line 35: """
Line 36: Detach the device from the host. This method *must* be
Line 43: return self._create_network_interface_xml()
Line 44: else:
Line 45: return self._create_generic_hostdev_xml()
Line 46:
Line 47: def _create_generic_hostdev_xml(self):
here _hostdev seems redundant.
_create_generic_xml()
seems a bit nicer
Line 48: """
Line 49: Create domxml for a host device.
Line 50:
Line 51: <devices>
Line 86: return hostdev
Line 87:
Line 88: def _create_network_interface_xml(self):
Line 89: """
Line 90: Create domxml for a host device.
this seems stale
Line 91:
Line 92: <devices>
Line 93: <interface type='hostdev' managed='no'>
Line 94: <driver name='vfio'/>
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list