Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

fromani at redhat.com fromani at redhat.com
Thu Mar 5 13:30:55 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


Patch Set 1:

(1 comment)

neat patch

https://gerrit.ovirt.org/#/c/38397/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 303:             response = self.destServer.migrationCreate(self._machineParams)
Line 304:             # Adds the time spent on migrationCreate to the startTime
Line 305:             startTime += time.time() - destinationCreateStartTime
Line 306:             self.log.info('Creation of destination VM took: %d seconds',
Line 307:                           time.time() - destinationCreateStartTime)
I'm 100% fine with the concept, but we can simplify the implementation. First thing, this is called like this

  self._startUnderlyingMigration(time.time())

on line 263 above. So, let's just get rid of the startTime argument, end let's move

  startTime = time.time() here below on line 308

or, maybe even better, let's do on line 328 below

  self._monitorThread - MonitorThread(self._vm, time.time())
Line 308: 
Line 309:             if response['status']['code']:
Line 310:                 self.status = response
Line 311:                 raise RuntimeError('migration destination error: ' +


-- 
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list