Change in vdsm[master]: hostdev: add hostdev device definition

mpolednik at redhat.com mpolednik at redhat.com
Thu Mar 5 09:33:22 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: add hostdev device definition
......................................................................


Patch Set 9: Verified+1

Tests: make check, schema tests, schema validation tests
Manual:
sent: {'type': 'hostdev', 'device': 'pci_0000_05_10_1', 'bootOrder': '1', 'specParams': {'bar': 'on', 'file': '/dev/zero'}
sent xml: 
                <hostdev managed="no" mode="subsystem" type="pci">
                        <source>
                                <address bus="5" domain="0" function="1" slot="16"/>
                        </source>
                        <boot order="1"/>
                        <rom bar="on" file="/dev/zero"/>
                </hostdev>
dumpxml:
    <hostdev mode='subsystem' type='pci' managed='no'>
      <driver name='vfio'/>
      <source>
        <address domain='0x0000' bus='0x05' slot='0x10' function='0x1'/>
      </source>
      <boot order='1'/>
      <alias name='hostdev0'/>
      <rom bar='on' file='/dev/zero'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </hostdev>

vm list:
{'specParams': {'bar': 'on', 'file': '/dev/zero'}, 'bootOrder': '1', 'alias': 'hostdev0', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'pci_0000_05_10_1', 'type': 'hostdev'} << NO DUPLICATE DEVICE! >>

Additionaly tested that alias and address is correctly sent back to engine with mbetak's backend, also device creation works that way.

-- 
To view, visit https://gerrit.ovirt.org/37700
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list