Change in vdsm[master]: virt: Additional reporting of CPU and IO information

fromani at redhat.com fromani at redhat.com
Wed Mar 4 16:52:34 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Additional reporting of CPU and IO information
......................................................................


Patch Set 2:

(2 comments)

almost there. docs in the schema deserve a little more love, other than that, looks good.

https://gerrit.ovirt.org/#/c/38366/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 6472: # @writeLatency:  The latency of write operations in nanoseconds
Line 6473: #
Line 6474: # @flushLatency:  The latency of flush operations in nanoseconds
Line 6475: #
Line 6476: # @writeOps:      Write operations (new in version 4.17.0)
"...operations performed so far"?
"number of ... operations"?
or something like it?

I'm don't want to be picky, just trying to avoid bad docs. Can be fixed in a later patch if no other change is needed.
Line 6477: #
Line 6478: # @readOps:       Read operations (new in version 4.17)
Line 6479: #
Line 6480: # @readBytes:     Bytes read (new in version 4.17.0)


https://gerrit.ovirt.org/#/c/38366/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 611:                     driveInfo = eInfo[vmDrive.name]
Line 612:                     dStats['readOps'] = str(driveInfo['rd_operations'])
Line 613:                     dStats['writeOps'] = str(driveInfo['wr_operations'])
Line 614:                     dStats['readBytes'] = str(driveInfo['rd_bytes'])
Line 615:                     dStats['writtenBytes'] = str(driveInfo['wr_bytes'])
thanks for the change.
In a later patch, we will reorganize this function to make it even more resilient in presence of missing keys. Which is unlikely indeed, hence no need to tackle it there.
Line 616: 
Line 617:             except (AttributeError, TypeError, ZeroDivisionError):
Line 618:                 self._log.exception("Disk %s stats not available",
Line 619:                                     vmDrive.name)


-- 
To view, visit https://gerrit.ovirt.org/38366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list