Change in vdsm[master]: stomp: use monotonic timer instead of clock

fromani at redhat.com fromani at redhat.com
Wed Mar 4 15:38:14 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: use monotonic timer instead of clock
......................................................................


Patch Set 1:

seems ok. The only possible issue that I could think of is that os.times() -thus utils.monotonic_time() has a reduced resolution with respect to time.time().

We discussed that during the review of https://gerrit.ovirt.org/#/c/35350/

Summary:
[os.times() has] 10 millisecond resolution (depending on configuration of HZ in the kernel).

If that reduced resolution is good for you, no issue here.

-- 
To view, visit https://gerrit.ovirt.org/37056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list