Change in vdsm[master]: virt: Additional reporting of CPU and IO information

fromani at redhat.com fromani at redhat.com
Wed Mar 4 11:49:56 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Additional reporting of CPU and IO information
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

minor mistakes instead, should be trivial to fix.

https://gerrit.ovirt.org/#/c/38366/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 6871: #
Line 6872: # @ioTune:             #optional Current QoS settings for IO devices
Line 6873: #                      (new in version 4.15.0)
Line 6874: #
Line 6875: # cpuShares:           #optional CPU shares accounted for this VM by the
missing leading @
Line 6876: #                      scheduler (new in version 4.17.0)
Line 6877: #
Line 6878: # Since: 4.10.0
Line 6879: ##


https://gerrit.ovirt.org/#/c/38366/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 607:                     # will be None if sampled during recovery
Line 608:                     dStats.update(_calcDiskRate(vmDrive, sInfo, eInfo,
Line 609:                                                 sampleInterval))
Line 610:                     dStats.update(_calcDiskLatency(vmDrive, sInfo, eInfo))
Line 611:                     dStats.update({
It should be fairly safe to do that here, because we use these fields already for disk rate and latency. But I'd rather use simple item setting, e.g.

  dStats['readOps'] = str(eInfo[vmDrive.name]['rd_operations'])
Line 612:                         'readOps': str(eInfo[vmDrive.name]['rd_operations']),
Line 613:                         'writeOps': str(eInfo[vmDrive.name]['rd_operations']),
Line 614:                         'readBytes': eInfo[vmDrive.name]['rd_bytes'],
Line 615:                         'writtenBytes': eInfo[vmDrive.name]['rd_bytes']})


Line 609:                                                 sampleInterval))
Line 610:                     dStats.update(_calcDiskLatency(vmDrive, sInfo, eInfo))
Line 611:                     dStats.update({
Line 612:                         'readOps': str(eInfo[vmDrive.name]['rd_operations']),
Line 613:                         'writeOps': str(eInfo[vmDrive.name]['rd_operations']),
s/rd_/wr_/
Line 614:                         'readBytes': eInfo[vmDrive.name]['rd_bytes'],
Line 615:                         'writtenBytes': eInfo[vmDrive.name]['rd_bytes']})
Line 616: 
Line 617:             except (AttributeError, TypeError, ZeroDivisionError):


Line 611:                     dStats.update({
Line 612:                         'readOps': str(eInfo[vmDrive.name]['rd_operations']),
Line 613:                         'writeOps': str(eInfo[vmDrive.name]['rd_operations']),
Line 614:                         'readBytes': eInfo[vmDrive.name]['rd_bytes'],
Line 615:                         'writtenBytes': eInfo[vmDrive.name]['rd_bytes']})
s/rd_/wr_/
Line 616: 
Line 617:             except (AttributeError, TypeError, ZeroDivisionError):
Line 618:                 self._log.exception("Disk %s stats not available",
Line 619:                                     vmDrive.name)


-- 
To view, visit https://gerrit.ovirt.org/38366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list