Change in vdsm[master]: hostdev: fix creation and deletion of multiple udev rules

danken at redhat.com danken at redhat.com
Wed Mar 4 11:16:21 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: fix creation and deletion of multiple udev rules
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38208/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 313:                 '/dev/vfio/{}"').format(iommu_group, EXT_CHOWN,
Line 314:                                         QEMU_PROCESS_USER, QEMU_PROCESS_GROUP,
Line 315:                                         iommu_group)
Line 316: 
Line 317:         if not os.path.isfile(ruleFile):
this condition can be placed higher.
Line 318:             # If the file exists, different device from the same group has
Line 319:             # already been detached and we therefore can skip overwriting the
Line 320:             # file. Also, this file should only be created/removed via the
Line 321:             # means of supervdsm, therefore no races should occur.


-- 
To view, visit https://gerrit.ovirt.org/38208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list