Change in vdsm[master]: storage: introducing vdsm-dump-chains script
ibarkan at redhat.com
ibarkan at redhat.com
Wed Mar 4 09:33:30 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script
......................................................................
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/38281/6/client/vdsm_dump_chains.py
File client/vdsm_dump_chains.py:
Line 21: import sys
Line 22: import optparse
Line 23: import errno
Line 24: from vdsm import vdscli
Line 25: BLANK_UUID = '00000000-0000-0000-0000-000000000000'
I am not sure how to properly import this into the current directory. The current packaging of this script is not decided yet but in anyway this should be imported as a constant from a storage package. if it is already possible to import it now, please show me how.
Line 26:
Line 27: _USAGE = "usage: vdsm-dump-chains [options] <sd_UUID>"
Line 28:
Line 29:
Line 66: default=False, help="show additional volume info")
Line 67: parser.add_option('-u', '--NOSSL', action='store_false', dest='use_ssl',
Line 68: default=True, help="use SSL")
Line 69: parser.add_option('-H', '--host', default=vdscli._ADDRESS)
Line 70: parser.add_option('-p', '--port', default=vdscli._PORT)
_ADDRESS and _PORT should be made public in a different patch
Line 71: options, args = parser.parse_args()
Line 72: if len(args) != 1:
Line 73: parser.error(_USAGE)
Line 74: return args, options
Line 80: vol_info = vol_info_answer['info']
Line 81: return vol_info
Line 82:
Line 83:
Line 84: def _get_volumes_chains(sd_uuid, server):
vdscli implementation implies an order of an API call per volume. It might be worhtwhile to implement a getVolumesList option that retrieves volume info for each volume it returns.
Line 85: sp_uuid = _get_sp_uuid(server)
Line 86: images = _get_all_images(server, sd_uuid)
Line 87:
Line 88: volume_chains = {} # {image_uuid -> vol_chain}
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list