Change in vdsm[master]: qemu-img: Handle image end offset on different lines of output
nsoffer at redhat.com
nsoffer at redhat.com
Tue Mar 3 20:25:02 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: qemu-img: Handle image end offset on different lines of output
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38355/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 159: except _RegexSearchError:
Line 160: pass
Line 161: except:
Line 162: raise QImgError(rc, out, err,
Line 163: "unable to parse qemu-img check output")
If we don't find the output, this will return None. Previously we raised QImgError in this case.
Line 164:
Line 165:
Line 166: def convert(srcImage, dstImage, stop, srcFormat=None, dstFormat=None,
Line 167: backing=None, backingFormat=None):
https://gerrit.ovirt.org/#/c/38355/1/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line 350: """
Line 351:
Line 352:
Line 353: class CheckTests(TestCaseBase):
Line 354:
Lets add a negative test where we don't match anything and raise.
Line 355: def test_offset_with_stats(self):
Line 356: def call(cmd, **kw):
Line 357: out = ["No errors were found on the image.",
Line 358: "65157/98304 = 66.28% allocated, 0.00% fragmented, 0.00% "
--
To view, visit https://gerrit.ovirt.org/38355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list