Change in vdsm[master]: models: move IpConfig's members to NetDevice

osvoboda at redhat.com osvoboda at redhat.com
Tue Mar 3 14:35:45 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: models: move IpConfig's members to NetDevice
......................................................................


Patch Set 1:

ifcfg & Fedora 21: there was no regression in functional tests, which failed once with a very weird message (DHCPv6 lease unexpectedly found?!):

FAIL: testSetupNetworksAddDelDhcp(kwargs=(True, (4,))) (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 65, in wrapper
    return f(self, *args)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 224, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/testValidation.py", line 160, in wrapper
    return f(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1793, in testSetupNetworksAddDelDhcp
    self.assertEqual(net_attrs['dhcpv6'], dhcpv6)
AssertionError: True != False

-- 
To view, visit https://gerrit.ovirt.org/38103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30ce76e1b9f32f1f35fe5927ed6b1215f911ff89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list