Change in vdsm[master]: json-rpc: fix the Host.getVMList return value

danken at redhat.com danken at redhat.com
Tue Mar 3 12:46:11 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: json-rpc: fix the Host.getVMList return value
......................................................................


json-rpc: fix the Host.getVMList return value

Host.getVMList() should return either VmDefinition or
VmShortStatus depending on the parameter fullStatus.

The return value in case fullStatus=False was wrong,
as it was just a list of UUIDs, while VmShortStatus
is supposed to be a dictionary holding (at least)
vmId and vmStatus.

This change made life harder to Engine monitoring code.
Missing the status, Engine's monitoring had no choice
but to call Vm.getStats() after each getVmList(), and that
has a not-negligible performance cost.

This patch makes the JSON-RPC output compliant to the
schema, to what Engine's monitoring expects and also
to XML-RPC output.

Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117
Bug-Url: https://bugzilla.redhat.com/1196327
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38172
Reviewed-by: Omer Frenkel <ofrenkel at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Tested-by: Omer Frenkel <ofrenkel at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Omer Frenkel: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list