Change in vdsm[ovirt-3.5]: network: test: remove bond with removed enslaved nics

danken at redhat.com danken at redhat.com
Tue Mar 3 09:34:06 UTC 2015


Hello Petr Horáček,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/38311

to review the following change.

Change subject: network: test: remove bond with removed enslaved nics
......................................................................

network: test: remove bond with removed enslaved nics

Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba656
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38083
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/38311/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index fe9d359..ccf78cd 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2128,3 +2128,25 @@
             self.assertEqual(status, SUCCESS, msg)
             self.assertNetworkDoesntExist(NETWORK_NAME)
             self.assertBondDoesntExist(BONDING_NAME, nics)
+
+    @cleanupNet
+    def testSetupNetworksRemoveBondWithKilledEnslavedNics(self):
+        nic = dummy.create()
+        nics = [nic]
+        try:
+            status, msg = self.vdsm_net.setupNetworks(
+                {NETWORK_NAME:
+                    {'bonding': BONDING_NAME, 'bridged': False}},
+                {BONDING_NAME: {'nics': nics}}, NOCHK)
+            self.assertEqual(status, SUCCESS, msg)
+            self.assertNetworkExists(NETWORK_NAME)
+            self.assertBondExists(BONDING_NAME, nics)
+        finally:
+            dummy.remove(nic)
+
+        status, msg = self.vdsm_net.setupNetworks(
+            {NETWORK_NAME: {'remove': True}},
+            {BONDING_NAME: {'remove': True}}, NOCHK)
+        self.assertEqual(status, SUCCESS, msg)
+        self.assertNetworkDoesntExist(NETWORK_NAME)
+        self.assertBondDoesntExist(BONDING_NAME, nics)


-- 
To view, visit https://gerrit.ovirt.org/38311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba656
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list