Change in vdsm[master]: netinfo: children count of <interface/> is 0 which broke a c...

myakove at redhat.com myakove at redhat.com
Mon Mar 2 20:31:40 UTC 2015


Meni Yakove has posted comments on this change.

Change subject: netinfo: children count of <interface/> is 0 which broke a condition
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/38294/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 112:     for net, netname in allNets:
Line 113:         if netname.startswith(LIBVIRT_NET_PREFIX):
Line 114:             netname = netname[len(LIBVIRT_NET_PREFIX):]
Line 115:             nets[netname] = {}
Line 116:             xml = etree.fromstring(net.XMLDesc(0))
Why not use
try:
    interface = xml.find('.//interface')
    nets[netname]['iface'] = interface.get('dev')
    nets[netname]['bridged'] = False
except AttributeError:
    nets[netname]['bridge'] = xml.find('.//bridge').get('name')
    nets[netname]['bridged'] = True
Line 117:             interface = xml.find('.//interface')
Line 118:             if interface is not None:
Line 119:                 nets[netname]['iface'] = interface.get('dev')
Line 120:                 nets[netname]['bridged'] = False


-- 
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list