Change in vdsm[master]: netinfo: children count of <interface/> is 0 which broke a c...

danken at redhat.com danken at redhat.com
Mon Mar 2 20:06:52 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: children count of <interface/> is 0 which broke a condition
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/38294/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-03-02 19:06:51 +0100
Line 4: Commit:     Ondřej Svoboda <osvoboda at redhat.com>
Line 5: CommitDate: 2015-03-02 20:58:20 +0100
Line 6: 
Line 7: netinfo: children count of <interface/> is 0 which broke a condition
could you add that nicless network is perfectly valid definition in Vdsm.

We need a unit test for netinfo.networks().
Line 8: 
Line 9: Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58


-- 
To view, visit https://gerrit.ovirt.org/38294
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad89e7ac307fc6bc7f48a45d00b0f3a177cd58
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list