Change in vdsm[master]: asyncore: dynamic tick support
danken at redhat.com
danken at redhat.com
Mon Mar 2 16:07:08 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: asyncore: dynamic tick support
......................................................................
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 297: """
Line 298: return getattr(
Line 299: self.__impl,
Line 300: "next_check_interval",
Line 301: lambda d: None
d->s would have hinted that the arg to this lambda is a "self"
Line 302: )(self)
Line 303:
Line 304: def recv(self, buffer_size):
Line 305: try:
https://gerrit.ovirt.org/#/c/37057/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 399: n += 1
Line 400:
Line 401: return n
Line 402:
Line 403: def setHeartBeat(self, outgoing, incoming=0):
Please document that "outgoing" is in milliseconds.
Line 404: if incoming != 0:
Line 405: raise ValueError("incoming heart-beat not supported")
Line 406:
Line 407: self._update_outgoing_heartbeat()
Line 448: def next_check_interval(self, dispatcher):
Line 449: if self._outgoingHeartBeat == 0:
Line 450: return None
Line 451:
Line 452: return max(self._outgoing_heartbeat_expiration_interval, 0)
function call missing!
self._outgoing_heartbeat_expiration_interval()
The fact that this has passed without detection shows that the unit tests are not good enough. Please improve.
Line 453:
Line 454: def handle_write(self, dispatcher):
Line 455: if self._outbuf is None:
Line 456: try:
--
To view, visit https://gerrit.ovirt.org/37057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list