Change in vdsm[master]: [WIP] EVENTS

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 2 14:34:02 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: [WIP] EVENTS
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/38069/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 212: 
Line 213:     def _createAcceptor(self, host, port):
Line 214:         sslctx = self._createSSLContext()
Line 215: 
Line 216:         self._acceptor = MultiProtocolAcceptor(
having reactor instance in multiProtocolAcceptor should be one separate patch. please split
Line 217:             self._reactor,
Line 218:             host,
Line 219:             port,
Line 220:             sslctx


Line 330:             binding.start()
Line 331:         self.thread = threading.Thread(
Line 332:             target=self._reactor.process_requests,
Line 333:             name='Reactor thread'
Line 334:         )
not related
Line 335:         self.thread.setDaemon(True)
Line 336:         self.thread.start()
Line 337: 
Line 338:     def _getUUIDSpecPath(self, uuid):


-- 
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list