Change in vdsm[master]: vm: remove obfuscated use of errCode

fromani at redhat.com fromani at redhat.com
Mon Mar 2 10:25:17 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: vm: remove obfuscated use of errCode
......................................................................

vm: remove obfuscated use of errCode

_changeBlockDev used to return error code in a funny
convoluted way. This patch simplifies it using a plain
unsurprising errCode usage, with no changes in the final
output.

Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/38267/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 3f194b0..cd90ae1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3741,9 +3741,7 @@
         except Exception:
             self.log.debug("updateDeviceFlags failed", exc_info=True)
             self.cif.teardownVolumePath(drivespec)
-            return {'status': {'code': errCode['changeDisk']['status']['code'],
-                               'message': errCode['changeDisk']['status']
-                                                 ['message']}}
+            return errCode['changeDisk']
         if vmDev in self.conf:
             self.cif.teardownVolumePath(self.conf[vmDev])
 


-- 
To view, visit https://gerrit.ovirt.org/38267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list