Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Mar 2 10:13:44 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 219:
Line 220: def _handle_process_input(self, proc):
Line 221: re_copy_disk = re.compile(r'.*(Copying disk \d+/\d+).*')
Line 222: while not self._abort:
Line 223: line = proc.stdout.readline()
> This is my point exactly - parsing output should be separated from the flow
well, we're parsing just one line with the copy progress, that's it
Line 224:
Line 225: if line == '':
Line 226: self._handle_process_errors(proc)
Line 227: break
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list