Change in vdsm[master]: api: correct the order of parameters in _bridge_reconfigured
ibarkan at redhat.com
ibarkan at redhat.com
Mon Mar 2 09:51:27 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: api: correct the order of parameters in _bridge_reconfigured
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38256/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 753: if k not in ('bonding', 'nic', 'mtu'))
Line 754:
Line 755: def _bridge_reconfigured(current_conf, required_conf):
Line 756: return (_bridge_only_config(current_conf) !=
Line 757: _bridge_only_config(required_conf))
nit: why the double change? only line 755 should be changed
Line 758:
Line 759: if currently_bridged and _bridge_reconfigured(network_running_config,
Line 760: network_attrs):
Line 761: logging.debug("the bridge is being reconfigured")
--
To view, visit https://gerrit.ovirt.org/38256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list