Change in vdsm[master]: api: make _should_keep_bridge robust against missing running...

osvoboda at redhat.com osvoboda at redhat.com
Sun Mar 1 15:20:48 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: api: make _should_keep_bridge robust against missing running/persistent cfg
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/38239/1/vdsm/network/api.py
File vdsm/network/api.py:

Line 750:         return dict(
Line 751:             (k, v) for k, v in conf.iteritems()
Line 752:             if k not in ('bonding', 'nic', 'mtu'))
Line 753: 
Line 754:     # isn't the parameter order wrong?!
> the order is indeed wrong
Thanks.
Line 755:     def _bridge_reconfigured(required_conf, current_conf):
Line 756:         # we know nothing about the running/persistent configuration because
Line 757:         # it has been removed e.g. by shell_helper's emergency_net_cleanup
Line 758:         if current_conf is None or required_conf is None:


Line 755:     def _bridge_reconfigured(required_conf, current_conf):
Line 756:         # we know nothing about the running/persistent configuration because
Line 757:         # it has been removed e.g. by shell_helper's emergency_net_cleanup
Line 758:         if current_conf is None or required_conf is None:
Line 759:             return False
> but let's return True an throw away the bridge just in case, because we don
Corrected now. I think I misundestood _bridge_reconfigured's semantics.
Line 760: 
Line 761:         return (_bridge_only_config(required_conf) !=
Line 762:                 _bridge_only_config(current_conf))
Line 763: 


-- 
To view, visit https://gerrit.ovirt.org/38239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13a225f406e6140463e1ded2008de8444fc4e9e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list