Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
ybronhei at redhat.com
ybronhei at redhat.com
Sun Mar 1 13:37:43 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/35940/2/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 440:
Line 441: frameHandler = self._frameHandler
Line 442: while parser.pending > 0:
Line 443: frame = parser.popFrame()
Line 444: if hasattr(frameHandler, "handle_frame"):
you remove this hasattr check in next patch
Line 445: frameHandler.handle_frame(self, frame)
Line 446:
Line 447: def popFrame(self):
Line 448: return self._parser.popFrame()
--
To view, visit https://gerrit.ovirt.org/35940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list