Change in vdsm[master]: hostdev: fix address type for generic devices

mpolednik at redhat.com mpolednik at redhat.com
Tue Jun 30 11:22:44 UTC 2015


Martin Polednik has uploaded a new change for review.

Change subject: hostdev: fix address type for generic devices
......................................................................

hostdev: fix address type for generic devices

Change 155e823f refactored some common elements of generic and
interface passthrough, but added type to address element only in case
of interface. Using default empty type led to invalid address being
generated.

Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/43041/1

diff --git a/vdsm/virt/vmdevices/hostdevice.py b/vdsm/virt/vmdevices/hostdevice.py
index 2817250..38b9cc4 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -85,7 +85,10 @@
             type=CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']])
         source = hostdev.appendChildWithArgs('source')
 
-        self._add_source_address(source)
+        self._add_source_address(
+            source,
+            type=CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']]
+        )
 
         return hostdev
 


-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>


More information about the vdsm-patches mailing list