Change in vdsm[master]: tests: Add @recorded method decorator

mpolednik at redhat.com mpolednik at redhat.com
Tue Jun 30 08:38:02 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: tests: Add @recorded method decorator
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43015/3//COMMIT_MSG
Commit Message:

Line 14: method you want to record:
Line 15: 
Line 16:     class Foo:
Line 17:         def __init__(self):
Line 18:             self.__recording__ = []
This is not very nice in a sense that in order to use recording, you have to do internal modification. Is it possible to use inheritance to implement this?
Line 19:         @recorded
Line 20:         def foo(self, a, b, c=3):
Line 21:             pass
Line 22:         def bar(self):


-- 
To view, visit https://gerrit.ovirt.org/43015
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c7750ae1deb5fa9bbee40d9f6f624ce1105c4e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list