Change in vdsm[ovirt-3.5]: net: typo in KernelConfig

ibarkan at redhat.com ibarkan at redhat.com
Tue Jun 30 06:25:27 UTC 2015


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/43028

to review the following change.

Change subject: net: typo in KernelConfig
......................................................................

net: typo in KernelConfig

Change-Id: I236e8f0422143bab2708300e2de82f48ae5e4755
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42906
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netconfpersistence.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/43028/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 5b8cb66..ee5039d 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -193,9 +193,9 @@
     def __init__(self, netinfo):
         super(KernelConfig, self).__init__({}, {})
         self._netinfo = netinfo
-        for net, net_attr in self._analize_netinfo_nets(netinfo):
+        for net, net_attr in self._analyze_netinfo_nets(netinfo):
             self.setNetwork(net, net_attr)
-        for bond, bond_attr in self._analize_netinfo_bonds(netinfo):
+        for bond, bond_attr in self._analyze_netinfo_bonds(netinfo):
             self.setBonding(bond, bond_attr)
 
     def __eq__(self, other):
@@ -203,11 +203,11 @@
         return (self.networks == normalized_other.networks
                 and self.bonds == normalized_other.bonds)
 
-    def _analize_netinfo_nets(self, netinfo):
+    def _analyze_netinfo_nets(self, netinfo):
         for net, net_attr in netinfo.networks.iteritems():
             yield net, self._translate_netinfo_net(net, net_attr)
 
-    def _analize_netinfo_bonds(self, netinfo):
+    def _analyze_netinfo_bonds(self, netinfo):
         for bond, bond_attr in netinfo.bondings.iteritems():
             yield bond, self._translate_netinfo_bond(bond_attr)
 


-- 
To view, visit https://gerrit.ovirt.org/43028
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I236e8f0422143bab2708300e2de82f48ae5e4755
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list