Change in vdsm[ovirt-3.5]: net: introducing KernelConfig
ibarkan at redhat.com
ibarkan at redhat.com
Tue Jun 30 05:58:35 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: net: introducing KernelConfig
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42960/3/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 202: normalized_other = self._normalize(other)
Line 203: return (self.networks == normalized_other.networks
Line 204: and self.bonds == normalized_other.bonds)
Line 205:
Line 206: def _analyze_netinfo_nets(self, netinfo):
> squashing commit 3de08722 into here is suboptimal. it could have been bette
Done
Line 207: for net, net_attr in netinfo.networks.iteritems():
Line 208: yield net, self._translate_netinfo_net(net, net_attr)
Line 209:
Line 210: def _analyze_netinfo_bonds(self, netinfo):
Line 231: attributes['hostQos'] = self._remove_zero_values_in_net_qos(
Line 232: net_attr['hostQos'])
Line 233:
Line 234: def _translate_ipaddr(self, attributes, net_attr):
Line 235: attributes['bootproto'] = net_attr['bootproto4']
> net_attr['dhcpv6'] is missing in the stable branch?
it is.
Line 236: ifcfg = net_attr.get('cfg')
Line 237: # TODO: we must not depend on 'cfg', which is configurator-dependent.
Line 238: # TODO: Look up in the routing table instead.
Line 239: if ifcfg and ifcfg.get('DEFROUTE') == 'yes':
--
To view, visit https://gerrit.ovirt.org/42960
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list