Change in vdsm[ovirt-3.5]: net: Drop default bonding options

danken at redhat.com danken at redhat.com
Mon Jun 29 19:43:27 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Drop default bonding options
......................................................................


net: Drop default bonding options

On old engines, no bonding options were provided to VDSM and it
used to configure it's own default options. Nowadays, those options
are always provided by engine. If a user will setup a network on an
existing bond, VDSM takes ownership of the bond and configures the
options on it.
The code for the default options was very local and options were
set 'too late' to be persisted. Hence this code was incorrect and
is not needed anyway.
The change in behavior is that from now on, if a bond with no options
is explicitly requested, the kernel will be asked to create a bond
without any options making the default kernel options effective.

Change-Id: I9e4a8d832891f62d1fcc412606b014fa4f874062
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203422
Reviewed-on: https://gerrit.ovirt.org/42594
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42959
---
M tests/functional/networkTests.py
M vdsm/network/models.py
2 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42959
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e4a8d832891f62d1fcc412606b014fa4f874062
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list