Change in vdsm[master]: gluster:refactor: User specified backup servers option

ahino at redhat.com ahino at redhat.com
Mon Jun 29 14:26:39 UTC 2015


Ala Hino has uploaded a new change for review.

Change subject: gluster:refactor: User specified backup servers option
......................................................................

gluster:refactor: User specified backup servers option

Move handling user specified backup servers option from
_get_backup_servers_option method to options property.

Change-Id: I4238328cfe230852182a1d997bd51b00f686f4a8
Signed-off-by: Ala Hino <ahino at redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/43003/1

diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 3d62694..e71b88c 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -297,7 +297,11 @@
 
     @property
     def options(self):
-        backup_servers_option = self._get_backup_servers_option()
+        if "backup-volfile-servers" in self._options:
+            self.log.warn("Using user specified backup-volfile-servers option")
+            backup_servers_option = ""
+        else:
+            backup_servers_option = self._get_backup_servers_option()
         return ",".join(
             p for p in (self._options, backup_servers_option) if p)
 
@@ -313,10 +317,6 @@
             raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
 
     def _get_backup_servers_option(self):
-        if "backup-volfile-servers" in self._options:
-            self.log.warn("Using user specified backup-volfile-servers option")
-            return ""
-
         servers = [brick.split(":")[0] for brick in self.volinfo['bricks']]
         servers.remove(self._volfileserver)
         if not servers:


-- 
To view, visit https://gerrit.ovirt.org/43003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4238328cfe230852182a1d997bd51b00f686f4a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>


More information about the vdsm-patches mailing list