Change in vdsm[master]: tests: Record fake domain calls in a list

mpolednik at redhat.com mpolednik at redhat.com
Mon Jun 29 13:52:22 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: tests: Record fake domain calls in a list
......................................................................


Patch Set 1: Code-Review-1

I'll play the opposite role: I don't have any issue with the code as is, but I believe that improvement is possible. In future, this would leave to boilerplate inside method bodies, which is not very nice. If we want to keep being explicit about call logging, what about decorator?

-- 
To view, visit https://gerrit.ovirt.org/42998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279a1fd7a2e07b7adef4f446c9487a51d9df21f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list