Change in vdsm[master]: virt: fix functional test graphics device for ppc64le
mpolednik at redhat.com
mpolednik at redhat.com
Mon Jun 29 11:14:54 UTC 2015
Martin Polednik has posted comments on this change.
Change subject: virt: fix functional test graphics device for ppc64le
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42727/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 59:
Line 60: VM_MINIMAL_UPTIME = 30
Line 61:
Line 62: _GRAPHICS_FOR_ARCH = {caps.Architecture.PPC64LE: 'vnc',
Line 63: caps.Architecture.X86_64: 'qxl'}
> I just wonder if this should be moved in virt/vmdevices/graphics.py
I'd probably keep this contained in tests for the time being, then see if it makes sense to expose this further.
Line 64:
Line 65:
Line 66: class VDSMConnectionError(Exception):
Line 67: pass
Line 231: @requireKVM
Line 232: def testSimpleVm(self):
Line 233: customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Line 234: 'vmName': 'testSimpleVm',
Line 235: 'display': _GRAPHICS_FOR_ARCH[platform.machine()]}
> maybe
Not sure I want another translation for the time being (close to above).
Line 236:
Line 237: with RunningVm(self.vdsm, customization) as vm:
Line 238: self._waitForStartup(vm, VM_MINIMAL_UPTIME)
Line 239: self._verifyDevices(vm)
--
To view, visit https://gerrit.ovirt.org/42727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8949557addd644f8f1a9bc631622bfd307dec9d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list