Change in vdsm[master]: gluster:refactor: Refactor GlusterFSConnection class
nsoffer at redhat.com
nsoffer at redhat.com
Mon Jun 29 11:08:08 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42952/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 283: options=options,
Line 284: mountClass=mountClass)
Line 285: self._backup_servers_option = None
Line 286: self._volinfo = None
Line 287: self._volfileServer, volname = self._remotePath.split(":", 1)
Please use lowercase - self._volfileserver.
Line 288: self._volname = volname.strip('/')
Line 289:
Line 290: @property
Line 291: def options(self):
Line 284: mountClass=mountClass)
Line 285: self._backup_servers_option = None
Line 286: self._volinfo = None
Line 287: self._volfileServer, volname = self._remotePath.split(":", 1)
Line 288: self._volname = volname.strip('/')
Please explain in the commit message why you are adding self._volfileServer and self.volname.
Line 289:
Line 290: @property
Line 291: def options(self):
Line 292: if self._backup_servers_option is None:
--
To view, visit https://gerrit.ovirt.org/42952
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3014723e1e3d1164a986f5e04208e199396b21b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list