Change in vdsm[master]: gluster: Verify volume is Replica 3

nsoffer at redhat.com nsoffer at redhat.com
Mon Jun 29 11:01:18 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 40: Code-Review-1

(2 comments)

-1 for visibility

https://gerrit.ovirt.org/#/c/41931/40/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 124: 
Line 125:         def glusterVolumeInfo(volname=None, volfileServer=None):
Line 126:             return None
Line 127: 
Line 128:         storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
This may be needed by older versions on this patch, but now it should not be needed. When we access gluster.options, we don't access gluster.volinfo because we return early if self._options contains the backup-volfile-servers option.
Line 129: 
Line 130:         user_options = "backup-volfile-servers=server1:server2"
Line 131:         gluster = GlusterFSConnection(spec="192.168.122.1:/music",
Line 132:                                       options=user_options)


https://gerrit.ovirt.org/#/c/41931/40/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 298
Line 299
Line 300
Line 301
Line 302
This check should be in options() - you should not access self._options in many places, better access it only in options() and let other code access self.options.


-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 40
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list