Change in vdsm[master]: hook: diskunmap: To include UNMAP support for disk and lun d...

danken at redhat.com danken at redhat.com
Sun Jun 28 14:30:13 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/29770/7/vdsm_hooks/diskunmap/before_vm_start.py
File vdsm_hooks/diskunmap/before_vm_start.py:

Line 43:         device = disk.getAttribute('device')
Line 44:         target = disk.getElementsByTagName('target')[0]
Line 45:         bus = target.getAttribute('bus')
Line 46:         if ((device == 'disk' or device == 'lun')
Line 47:            and (bus == 'scsi' or bus == 'ide')):
Why not virtio?
Line 48:             driver = disk.getElementsByTagName('driver')[0]
Line 49:             driver.setAttribute('discard', 'unmap')
Line 50: 
Line 51: 


-- 
To view, visit https://gerrit.ovirt.org/29770
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36385f1af24043755b3d4b6594bbe598b0d9518d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list