Change in vdsm[master]: net: use KernelConfig instead of RunningConfig in setupNetworks

ibarkan at redhat.com ibarkan at redhat.com
Fri Jun 26 08:41:07 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: use KernelConfig instead of RunningConfig in setupNetworks
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42903/1/vdsm/network/api.py
File vdsm/network/api.py:

Line 860: 
Line 861:     logger.debug("Applying...")
Line 862:     in_rollback = options.get('_inRollback', False)
Line 863:     kernel_config = netconfpersistence.KernelConfig(_netinfo)
Line 864:     normalized_config = kernel_config.normalize(
> I did not think about normalization myself (and the commit message does not
Done. we can never compare the two directly. just as we cannot during restoration (the comparison actually takes place in _bridge_reconfigured).
Line 865:         netconfpersistence.BaseConfig(networks, bondings))
Line 866:     with ConfiguratorClass(in_rollback) as configurator:
Line 867:         # Remove edited networks and networks with 'remove' attribute
Line 868:         for network, attrs in networks.items():


-- 
To view, visit https://gerrit.ovirt.org/42903
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41232de5b079e6192b3c0f031d0cb24036583c43
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list