Change in vdsm[master]: net: handle defaultRoute correctly

ibarkan at redhat.com ibarkan at redhat.com
Thu Jun 25 19:06:15 UTC 2015


Ido Barkan has uploaded a new change for review.

Change subject: net: handle defaultRoute correctly
......................................................................

net: handle defaultRoute correctly

Before the fix, the code might leave the normalized config without
a 'defaultRoute' key.

Change-Id: I20a42c4afba52c8fdee0b4a8193e2e5a0b92068a
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
---
M lib/vdsm/netconfpersistence.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/42905/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 5cb62b7..da0a5aa 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -379,8 +379,7 @@
                 net_attr['netmask'] = self._netinfo.prefix2netmask(int(prefix))
             if 'ipv6addr' in net_attr:
                 net_attr['ipv6addr'] = [net_attr['ipv6addr']]
-            if 'defaultRoute' not in net_attr:
-                net_attr['defaultRoute'] = False
+            net_attr['defaultRoute'] = net_attr.get('defaultRoute', False)
 
     def _parse_bond_options(self, opts):
         if not opts:


-- 
To view, visit https://gerrit.ovirt.org/42905
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20a42c4afba52c8fdee0b4a8193e2e5a0b92068a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list