Change in vdsm[master]: migration: make downtime steps instance attributes

danken at redhat.com danken at redhat.com
Mon Jun 22 11:32:17 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: migration: make downtime steps instance attributes
......................................................................


migration: make downtime steps instance attributes

Move the DowntimeThread steps from class constant
to instance attribute, to make the code more testable.

Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/42578
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmMigrationTests.py
M tests/vmfakelib.py
M vdsm/virt/migration.py
3 files changed, 52 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/42578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list