Change in vdsm[master]: Introducing systemctl configurator to enable vdsm required s...

ybronhei at redhat.com ybronhei at redhat.com
Mon Jun 22 10:08:13 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Introducing systemctl configurator to enable vdsm required services
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/42605/2/lib/vdsm/tool/configurators/systemctl.py
File lib/vdsm/tool/configurators/systemctl.py:

Line 25: 
Line 26: from vdsm.tool import service
Line 27: 
Line 28: 
Line 29: REQUIRED_SERVICES = ['vdsmd', 'supervdsmd', 'vdsm-network', 'mom-vdsm']
> I'd add the .service although it works quite well without.
explain why ...
Line 30: 
Line 31: 
Line 32: def isconfigured():
Line 33:     """


-- 
To view, visit https://gerrit.ovirt.org/42605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I796fefe13da9c0f5c7bc2b6cd5d7c98779a3f259
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list