Change in vdsm[master]: net: Drop default bonding options
ibarkan at redhat.com
ibarkan at redhat.com
Mon Jun 22 09:58:53 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: net: Drop default bonding options
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42594/3/vdsm/network/models.py
File vdsm/network/models.py:
Line 209: self.validateName(name)
Line 210: for slave in slaves:
Line 211: slave.master = self
Line 212: self.slaves = slaves
Line 213: self.options = options
default to an empty string
Line 214: if options:
Line 215: self.validateOptions(options)
Line 216: self.options = self._reorderOptions(options)
Line 217: self.destroyOnMasterRemoval = destroyOnMasterRemoval
Line 245:
Line 246: self.configurator.configureBond(self, **opts)
Line 247:
Line 248: def areOptionsApplied(self):
Line 249: if not self.options:
> is this really true?
big TODO here: should we fix the subset check to equal check
Line 250: return True
Line 251: confOpts = [option.split('=', 1) for option in self.options.split(' ')]
Line 252: activeOpts = netinfo.bondOpts(self.name,
Line 253: (name for name, value in confOpts))
--
To view, visit https://gerrit.ovirt.org/42594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4a8d832891f62d1fcc412606b014fa4f874062
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list