Change in vdsm[master]: libvirt: Replacing xml.dom.minidom with cElementTree module

mmirecki at redhat.com mmirecki at redhat.com
Mon Jun 22 09:00:02 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: libvirt: Replacing xml.dom.minidom with cElementTree module
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/38458/3/vdsm/network/configurators/libvirt.py
File vdsm/network/configurators/libvirt.py:

Line 70:     netName = netinfo.LIBVIRT_NET_PREFIX + network
Line 71: 
Line 72:     def EtreeElement(tagName, text=None, **attrs):
Line 73:         elem = etree.Element(tagName)
Line 74:         if text:
None of the EtreeElement invocations below use the 'text' attribute, so this looks like dead code.
Maybe we can remove this?
Line 75:             elem.text = escape(text)
Line 76:         if attrs:
Line 77:             for attr, value in attrs.iteritems():
Line 78:                 elem.set(attr, escape(str(value)))


-- 
To view, visit https://gerrit.ovirt.org/38458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0aff978b2397edaf3986bfbb8881cfa318d82d05
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list