Change in vdsm[master]: resize-lun: resizePV parameters

frolland at redhat.com frolland at redhat.com
Sun Jun 21 11:48:49 UTC 2015


Hello Fred Rolland,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/42608

to review the following change.

Change subject: resize-lun: resizePV parameters
......................................................................

resize-lun: resizePV parameters

In lvm.resizePV, we need all devices names in the filters parameters.
Otherwise the operation will fail. It is needed in case we have more
than one LUN on the storage domain.

Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899
Bug-Url:https://bugzilla.redhat.com/609689
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M vdsm/storage/lvm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/42608/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index f93e5b9..090dc14 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -877,7 +877,7 @@
     """
     pvName = _fqpvname(guid)
     cmd = ["pvresize", pvName]
-    rc, out, err = _lvminfo.cmd(cmd, (pvName,))
+    rc, out, err = _lvminfo.cmd(cmd)
     if rc != 0:
         raise se.CouldNotResizePhysicalVolume(pvName, err)
     _lvminfo._invalidatepvs(pvName)


-- 
To view, visit https://gerrit.ovirt.org/42608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>


More information about the vdsm-patches mailing list