Change in vdsm[master]: gluster: Verify volume is Replica 3

ahino at redhat.com ahino at redhat.com
Sun Jun 21 08:50:58 UTC 2015


Ala Hino has posted comments on this change.

Change subject: gluster: Verify volume is Replica 3
......................................................................


Patch Set 32:

(4 comments)

https://gerrit.ovirt.org/#/c/41931/32/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 372:     # Section: [gluster]
Line 373:     ('gluster', [
Line 374: 
Line 375:         ('allowed_replica_counts', '3',
Line 376:             'Only replica 3 is supported, this configuration is for'
> - Missing space at the end of the line.
Done
Line 377:             'development. Values are comma separated.'
Line 378:             'For example, to allow replica 1 and replica 3, use 1,3'),
Line 379:     ]),
Line 380: 


Line 373:     ('gluster', [
Line 374: 
Line 375:         ('allowed_replica_counts', '3',
Line 376:             'Only replica 3 is supported, this configuration is for'
Line 377:             'development. Values are comma separated.'
> - Values -> Value
Done
Line 378:             'For example, to allow replica 1 and replica 3, use 1,3'),
Line 379:     ]),
Line 380: 
Line 381: ]


Line 374: 
Line 375:         ('allowed_replica_counts', '3',
Line 376:             'Only replica 3 is supported, this configuration is for'
Line 377:             'development. Values are comma separated.'
Line 378:             'For example, to allow replica 1 and replica 3, use 1,3'),
> - Missing "." at the end of the sentence.
Done
Line 379:     ]),
Line 380: 
Line 381: ]
Line 382: 


https://gerrit.ovirt.org/#/c/41931/32/vdsm/storage/storage_exception.py
File vdsm/storage/storage_exception.py:

Line 1200:     code = 480
Line 1201:     message = "Gluster volume replica count is not supported"
Line 1202: 
Line 1203:     def __init__(self, replicaCount):
Line 1204:         self.replicaCount = replicaCount
> You should set self.value here - otherwise your exception will render like 
Done.
Exception now renders like this:
UnsupportedGlusterVolumeReplicaCountError: Gluster volume replica count is not supported: 'replica count = 2'
Line 1205: 
Line 1206: 
Line 1207: #################################################
Line 1208: #  LVM related Exceptions


-- 
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list