Change in vdsm[master]: test: make sure that jsonrpc test timeout

danken at redhat.com danken at redhat.com
Sat Jun 20 22:44:50 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: test: make sure that jsonrpc test timeout
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

-1 for visibility.

https://gerrit.ovirt.org/#/c/42541/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 327:                 },
Line 328:                 message
Line 329:             )
Line 330:             # we need to check whether the channel is not closed
Line 331:             if not connection.client.is_closed():
the commit message completely ignores this change.

would you please explain it?

do we not care that something may call connection.client.close() just before (or during) send_raw()?
Line 332:                 connection.client.send_raw(res)
Line 333: 
Line 334: 
Line 335: class StompClient(object):


-- 
To view, visit https://gerrit.ovirt.org/42541
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51b2cf980c3c51467f7b0bef677d8b2bbdd43bf5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list