Change in vdsm[master]: virt: use new mocking in hostdevTests

mpolednik at redhat.com mpolednik at redhat.com
Fri Jun 19 23:41:33 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: virt: use new mocking in hostdevTests
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 206: 
Line 207: class Connection(fake.Connection):
Line 208: 
Line 209:     def __init__(self, *args):
Line 210:         self._virNodeDevices = []
> self._virNodeDevices = [
yep! will coolify
Line 211: 
Line 212:         for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES:
Line 213:             self._virNodeDevices.append(self.nodeDeviceLookupByName(device))
Line 214: 


Line 212:         for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES:
Line 213:             self._virNodeDevices.append(self.nodeDeviceLookupByName(device))
Line 214: 
Line 215:     def listAllDevices(self, flags=0):
Line 216:         return self._virNodeDevices
> frankly, we don't really need the _virNodeDevices cache - we can listdir() 
good point, will fix
Line 217: 
Line 218: 
Line 219: def _fake_totalvfs(device_name):
Line 220:     if device_name == 'pci_0000_05_00_1':


-- 
To view, visit https://gerrit.ovirt.org/40905
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e21dcaf6f645acb8229c01f40569785e1416cc2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list